أحسن الله إليكم Ustadh could you please tell me how to have constant good thoughts of Allah? I’ve been making a certain dua for a year and sometimes I feel hopeless (even after taking all of the means)

So, for a whole year you have been getting all of these hasanat what are we to complain about? We do not even know how much Allah has protected and pushed away from us when we make dua, even what are asking for can be harmful to us and Allah knows that, so He is giving you what is better. There is nothing to complain about, but to act more and more.